Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/shell/ping: print error when DNS resolve fails #20353

Merged
merged 2 commits into from
Feb 7, 2024
+3 −1
Merged

sys/shell/ping: print error when DNS resolve fails #20353

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfdda46
sys/shell/ping: print error when DNS resolve fails
benpicco Feb 7, 2024
23c8336
tests/net/gcoap_fileserver: add atmega1284p to Makefile.ci
benpicco Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sys/shell/cmds/gnrc_icmpv6_echo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@

res = netutils_get_ipv6(&data->host, (netif_t **)&data->netif, arg);
if (res) {
break;
printf("can't resolve %s\n", arg);
return res;
}
}
else {
Expand All @@ -210,7 +211,7 @@
if ((++i) < argc) {
value = atoi(argv[i]);

if ((value < 0) || ((unsigned)value > (UINT16_MAX - sizeof(icmpv6_hdr_t)))) {

Check warning on line 214 in sys/shell/cmds/gnrc_icmpv6_echo.c

View workflow job for this annotation

GitHub Actions / static-tests 

line is longer than 100 characters
printf("ping size should be in range 0-65527.\n");
return -1;
}
Expand Down
Loading