-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/msp430/f2xx: clean up periph_uart,periph_spi #20357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
State: waiting for other PR
State: The PR requires another PR to be merged first
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Feb 7, 2024
maribu
requested review from
miri64,
leandrolanzieri,
aabadie,
MichelRottleuthner,
kaspar030 and
gschorcht
as code owners
February 7, 2024 19:42
github-actions
bot
added
Platform: MSP
Platform: This PR/issue effects MSP-based platforms
Area: doc
Area: Documentation
Area: tests
Area: tests and testing framework
Area: boards
Area: Board ports
Area: cpu
Area: CPU/MCU ports
Area: examples
Area: Example Applications
labels
Feb 7, 2024
benpicco
removed
the
State: waiting for other PR
State: The PR requires another PR to be merged first
label
Feb 8, 2024
maribu
force-pushed
the
cpu/msp430/usci
branch
from
February 9, 2024 21:49
494ae40
to
3b17adb
Compare
maribu
force-pushed
the
cpu/msp430/usci
branch
from
February 13, 2024 09:51
382cdee
to
71ea5c8
Compare
benpicco
approved these changes
Mar 27, 2024
This cleans up the USCI based UART and SPI implementations and allows multiple instances of either interface to be configured by the boards. In addition, it allows sharing the USCI peripherals to provide multiple serial interfaces with the same hardware (round-robin).
Ran `dist/tools/insufficient_memory/update_insufficient_memory_board.sh` for both `z1` and `olimex-msp430-h2618`.
Wooohooo 🎉 Thx! |
This was referenced Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: boards
Area: Board ports
Area: cpu
Area: CPU/MCU ports
Area: examples
Area: Example Applications
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: MSP
Platform: This PR/issue effects MSP-based platforms
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This cleans up the USCI based UART and SPI implementations and allows
multiple instances of either interface to be configured by the
boards. In addition, it allows sharing the USCI peripherals to provide
multiple serial interfaces with the same hardware (round-robin).
Testing procedure
With an PCB sandwich consisting of an
olimex-msp430-h2618
plugged into our Arduino UNO adapter and our peripheral selftest shield plugged into the other side of said adapter (so that SPI MISO and MOSI are conntected):Issues/PRs references
Depends on and includes: #20356