-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc_ipv6_nib/SLAAC: rfc7217 stable privacy addresses #20370
Open
xnumad
wants to merge
36
commits into
RIOT-OS:master
Choose a base branch
from
xnumad:rfc7217
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+516
−27
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
110fa3c
config: Define feature flag
xnumad 60933a5
🍒SLAAC only for /64 prefixes
xnumad fd01be3
🍒Documentation for constant
xnumad 6774248
🍒Documentation
xnumad 828ac9d
🍒creation: Check IANA IID
xnumad 6b5424a
Wrap IANA IID check in IS_ACTIVE
xnumad 227181a
🍒gnrc_netif_ipv6_addr_pfx_idx
xnumad 3c9e0d0
🍒Supress SLAAC trigger
xnumad 356b3d9
🍒retries: New flag
xnumad f934340
Wrap retries flag in IS_ACTIVE
xnumad 1836de5
config: RFC params
xnumad fa015a2
includes
xnumad 6340dcd
IDGEN
xnumad 20375dd
Generate secret_key at compilation
xnumad 0a31c73
Retry condition check
xnumad ec7caef
Overload method
xnumad 758b838
Use IDGEN
xnumad 30914b7
Handle DAD
xnumad cb846fd
Fix `unused-function`
xnumad ff81306
IDGEN error handling and logging
xnumad e9a5b1c
Allow rfc7217 IDGEN without L2 addr
xnumad 8bc9b10
Perform DAD for RPL PIO
xnumad f96b610
RFC7217 for NETOPT_IPV6_IID
xnumad f544165
Rename method
xnumad 4635a2e
Rename method
xnumad 46b1107
No RFC7217 for 6LN link-local addresses
xnumad 63e98ac
IDGEN: require L2 addr
xnumad 0962383
finalize: vera++ style check
xnumad ca4f23a
Wrap
xnumad 36fb6b3
doccheck
xnumad af35c11
chore: Use C-style comments
xnumad a69adaa
refactor: Make called function inline
xnumad dfb5e1d
refactor: Rename
xnumad 35e2326
fix: Don't generate already assigned addresses
xnumad 6cbd58d
fixup! RFC7217 for NETOPT_IPV6_IID
xnumad 3af0785
fix: Idempotency wrapper for callers
xnumad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to think a bit about device individualization in RIOT as a whole (esp. for questions like "is this maybe better created in a HWRNG assisted way at first start?"), but until then, passing it into the build seems fine.
As someone who repeatedly flashes devices and then starts network interactions, it may be convenient to store this in the build directory and recreate only if absent, as that will make addresses stable across rebuilds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely agree, letting the board generate the secret_key by itself (and permanently store it - as per the RFC) would be more convenient, as a future improvement!