Remove Kconfig dependency modelling #20438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKevinWeiss
requested review from
leandrolanzieri,
jia200x,
jeandudey,
aabadie,
MichelRottleuthner,
vincent-d,
benpicco,
dylad,
keestux,
gschorcht,
basilfx,
kYc0o,
maribu and
nandojve
as code owners
github-actions
bot
added
Platform: native
This was referenced Mar 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
oh boy am I sad... OK back at it. |
|
Not only does the gcoap test fail, but also it seems like there are some issues with |
MrKevinWeiss
force-pushed
the
pr/kconfig/dep/removal
branch
from
f4441e0 to
d265330
Compare
|
hmmm, way less of a problem than I though... just a conflict in values for |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Hmmm the failed test builds on my machine. Maybe something to do with rust on a CI machine? |
|
🎉 Thx! |
|
I didn't think I would make it. Nice that it is finally over. I will also prioritize any issues or bugs this may have causes. |
|
Thank you for bringing the Kconfig transition to a close! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
As discussed on the forum and agreed upon in the VMA among other forms of communications we are removing the dependency modelling of Kconfig. As it was never part of the "production" RIOT and only available as an experimental feature (
TEST_KCONFIG=1) I do not think we need to deprecate it.This PR should remove everything dependency related but preserve all "kconfig for configurations" aspects.
It is a step in the direction of having "one source of truth" for configurations, many configurations that were only exposed when
TEST_KCONFIG=1are now exposed in a regular build (ie,depends on MODULE_*->depends on USEMODULE_). These configurations are still not being used by default (for any test that does not have an app.config file present) as to not slow down the CI before the release but will be switched very soon.There are quite some things needed in order to do this right:
MODULE_andPACKAGE_configs and symbol references within remaining filesCONFIG_that have been implemented under the dep modelling to use the make dep modelling (ie.MODULE_->USEMODULE_)Inject all the HAS_CPU* type featuresTesting procedure
Green murdock and a lot of looking through
Issues/PRs references
Needs #20497