tools/openocd: define SWD_EN signal for tigard #20507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The upstream OpenOCD config for Tigard does not define SWD_EN, as it can also be used in JTAG mode.
However, OpenOCD will complain when the signal is not set. A quick and dirty solution is directly editing
/usr/share/openocd/scripts/interface/ftdi/tigard.cfg
, but this is of course not a great user experience.To solve this, add the line from the example config to our OpenOCD command line if tigard is used in SWD mode.
Testing procedure
In
master
interacting with OpenOCD and Tigard either requires editingtigard.cfg
or you'll getWith this patch, everything works out of the box with the default
tigard.cfg
.Issues/PRs references