core: Guard pm_set_lowest with module_periph_pm #20508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area: core
Teufelchen1
force-pushed
the
core/guard_pm
branch
from
6c414a1 to
e3da305
Compare
MrKevinWeiss
changed the title
MrKevinWeiss
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
We actually noticed this in the GBA port, where the periph_pm was NOT provided and had a linking error. Normally periph_pm is brought in (for everything) with FEATURES_OPTIONAL which is why only the linker failed and not a missing feature message.
This is pretty straight forward, in files that are included everywhere, functions using optional modules should be guarded.
one ACK.
MrKevinWeiss
added
CI: ready for build
github-actions
bot
added
the
Process: missing approvals
|
One more ack would be nice :) |
benpicco
added
the
Impact: minor
benpicco
approved these changes
Mar 26, 2024
github-actions
bot
removed
the
Process: missing approvals
Teufelchen1
added a commit
to Teufelchen1/RIOT
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
🙃
I think
pm_set_lowest()needs to be guarded against the moduleperiph_pm. Otherwise you can not build RIOT ifperiph_pmis not provided by the target board.I wasn't super sure if it needs to be
periph_pmmaybe it should bepm_layeredinstead?Testing procedure
CI, I guess? Very unsure here!