Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcoap: make gcoap_req_send_tl() an alias of gcoap_req_send() #20514

Merged
merged 1 commit into from
Mar 28, 2024
Merged

gcoap: make gcoap_req_send_tl() an alias of gcoap_req_send() #20514

merged 1 commit into from
Mar 28, 2024

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 27, 2024 •
edited
Loading

Contribution description

The deprecation notice for gcoap_req_send_tl() says, it was supposed to be made an alias for gcoap_req_send() after the 2022.01 release. This never happened, so let's do that 2 years after ;-). As a consequence I bumped up the actual removal of gcoap_req_send_tl() to after the 2024.10 release.

Testing procedure

Should be straight forward, as gcoap_req_send() was a wrapper around gcoap_req_send_tl() with the default parameter GCOAP_SOCKET_TYPE_UNDEF already. As this adds that default parameter to all calls of gcoap_req_send(), nothing should change. So compilation should catch any issues.

Issues/PRs references

@miri64
gcoap: make gcoap_req_send_tl() an alias of gcoap_req_send()
2730858 
As per the deprecation notice from July 2021 ;-).
@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 27, 2024
@miri64 miri64 requested a review from Teufelchen1 March 27, 2024 11:28
@miri64 miri64 requested a review from PeterKietzmann as a code owner March 27, 2024 11:28
@github-actions github-actions bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System Area: examples Area: Example Applications labels Mar 27, 2024
Teufelchen1
Teufelchen1 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it but lgtm, trusting miri & CI

@riot-ci
Copy link

riot-ci commented Mar 27, 2024 •
edited
Loading

Murdock results

✔️ PASSED

2730858 gcoap: make gcoap_req_send_tl() an alias of gcoap_req_send()

Success Failures Total Runtime
10027 0 10027 17m:16s

Artifacts

@miri64
Copy link
Member Author

miri64 commented Mar 27, 2024

Seems unrelated

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 27, 2024
@miri64 miri64 enabled auto-merge March 27, 2024 14:08
@miri64 miri64 added this pull request to the merge queue Mar 27, 2024
Merged via the queue into RIOT-OS:master with commit a2e3ca0 Mar 28, 2024
34 checks passed
@miri64 miri64 deleted the gcoap/cleanup/gcoap_req_send_aliasing branch March 28, 2024 08:18
@miri64 miri64 mentioned this pull request Mar 28, 2024
Merged
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: examples Area: Example Applications Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @riot-ci @Teufelchen1 @MrKevinWeiss