sys/phydat: Remove deprecated print function #20529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teufelchen1
requested review from
miri64,
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
github-actions
bot
added
Area: tests
mguetschow
approved these changes
Apr 2, 2024
miri64
added
Type: cleanup
Co-authored-by: Marian Buschsieweke <[email protected]>
Teufelchen1
force-pushed
the
deprecate/phydat_str
branch
from
5774e02 to
96e748d
Compare
|
Sorry I didn't spot this when it was deprecated: This deprecation severly impacts usability in Rust (see also RIOT-OS/rust-riot-wrappers#86). While exploring possibilities, might we remove _verbose, but keep (undeprecate) phydat_unit_to_str as a function that is only available if not HAS_FLASH_UTILS_ARCH? |
chrysn
added a commit
to RIOT-OS/rust-riot-wrappers
that referenced
this pull request
Apr 3, 2024
…tions An underlying API change[20529] made the functions impossible to satisfy; as they are already fallible (and may have returned None if the list were reduced), returning None is a compatible-by-the-letter way out. [20529]: RIOT-OS/RIOT#20529 Co-Authored-By: Teufelchen1 <[email protected]> Closes: #86
This was referenced Apr 3, 2024
chrysn
added
CI: ready for build
|
For continuation of my question, see discussion in RIOT-OS/rust-riot-wrappers#86. Seems that going push-copy is the right thing to do here. Rust APIs are adjusted, and CI seems to be happy so far except for formalities (thanks to tests being only run on the merged commits -- something I'm not too happy with b/c it breaks bisection, but it is certainly convenient here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Hej 🫏
This removes the deprecated functions
phydat_unit_to_strandphydat_unit_to_str_verbose.In addition, I introduce a new unit test for the
phydat_unit_writefunction.Testing procedure
There are two tests here but I believe review & CI is enough.
make -C tests/sys/senml_phydat/ all-asan testmake -C tests/unittests/ all-asan tests-phydat testIssues/PRs references
Missing unit tests were overlooked and deprecation introduced in #18148