Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/sys/psa_crypto*: remove test symlinks #20545

Merged
merged 2 commits into from
May 14, 2024

Conversation

Einhornhool
Copy link
Contributor

The PSA configuration tests used symlinks of the files from examples/psa_crypto.
This lead to the issue that CI did not rebuild them for each of the tests and missed some boards with insufficient memories.

This PR removes the symlinks from the tests and cleans up some of the code.

Testing procedure

Run the tests successfully for all boards.

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Apr 5, 2024
@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 9, 2024
@MrKevinWeiss
Copy link
Contributor

There is also a label to disable the test cache if we need it.

@riot-ci
Copy link

riot-ci commented Apr 9, 2024

Murdock results

✔️ PASSED

545a4dd tests/sys/psa_crypto_ecdsa: Make stacksize backend dependent

Success Failures Total Runtime
153 0 153 03m:13s

Artifacts

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

For some reason, Github doesn't let me comment on the lines directly, but in several main.c files, you still have

    /* Needed in case only hashes are tested */
    (void)status;
    (void)start;

which is now superfluous, right?

Maybe it would also be a good idea to add a comment to the example_*.c files mentioning that they are copied from examples/psa_crypto.

Apart from that, LGTM :)

@Einhornhool
Copy link
Contributor Author

Thanks for cleaning this up!

For some reason, Github doesn't let me comment on the lines directly, but in several main.c files, you still have

    /* Needed in case only hashes are tested */
    (void)status;
    (void)start;

which is now superfluous, right?

Maybe it would also be a good idea to add a comment to the example_*.c files mentioning that they are copied from examples/psa_crypto.

Apart from that, LGTM :)

You're right. I updated the files :)

@mguetschow
Copy link
Contributor

You may then squash everything together 👍

@Einhornhool Einhornhool force-pushed the pr/psa-remove-test-symlinks branch from 23da36a to 2f98d21 Compare April 17, 2024 11:44
@Einhornhool Einhornhool force-pushed the pr/psa-remove-test-symlinks branch from 2f98d21 to a958332 Compare April 17, 2024 12:13
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@mguetschow mguetschow enabled auto-merge April 17, 2024 12:55
@mguetschow mguetschow added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@mguetschow mguetschow enabled auto-merge May 14, 2024 14:51
@mguetschow mguetschow added this pull request to the merge queue May 14, 2024
Merged via the queue into RIOT-OS:master with commit 12180f5 May 14, 2024
27 checks passed
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants