Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/shell/doc: Shell access is root access #20546

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Apr 5, 2024

Contribution description

To my understanding it is widely understood in the community that shell access is equivalent to root access on the device -- a) because modules are additive and shell commands are easily pulled in that allow all kinds of access, and b) because string parsing is hard.

This states this plainly in the documentation.

@chrysn chrysn added Area: doc Area: Documentation Area: security Area: Security-related libraries and subsystems labels Apr 5, 2024
@github-actions github-actions bot added Area: sys Area: System and removed Area: doc Area: Documentation Area: security Area: Security-related libraries and subsystems labels Apr 5, 2024
@chrysn chrysn added the Process: needs >1 ACK Integration Process: This PR requires more than one ACK label Apr 5, 2024
@github-actions github-actions bot added the Process: missing approvals Integration Process: PR needs more ACKS (handled by action) label Apr 5, 2024
@chrysn
Copy link
Member Author

chrysn commented Apr 5, 2024

I'm setting this to "needs >1 ACK" without any formal need because it's a statement of very broad expectations.

@maribu maribu enabled auto-merge April 5, 2024 18:41
@github-actions github-actions bot removed the Process: missing approvals Integration Process: PR needs more ACKS (handled by action) label Apr 6, 2024
@chrysn chrysn added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 6, 2024
@riot-ci
Copy link

riot-ci commented Apr 6, 2024

Murdock results

✔️ PASSED

df62568 sys/shell/doc: Shell access is root access

Success Failures Total Runtime
1 0 1 01m:00s

Artifacts

@maribu maribu added this pull request to the merge queue Apr 6, 2024
Merged via the queue into RIOT-OS:master with commit 8bb8c5b Apr 6, 2024
28 of 31 checks passed
@chrysn chrysn deleted the doc-shell-no-security branch April 6, 2024 10:18
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs >1 ACK Integration Process: This PR requires more than one ACK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants