tests/sys/shell: increase the stack size of periodic thread #20548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the test seems to be broken with LLVM toolchain Signed-off-by: dylad <[email protected]>
dylad
added
CI: ready for build
dylad
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
maribu
approved these changes
Apr 6, 2024
|
Chances are high that this needs the |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Yep, the ATmega328P boards no longer fit. |
|
round 2. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dylad
force-pushed
the
pr/tests/sys/shell/fix_ci_error_llvm
branch
3 times, most recently
from
adbf7ec to
2ebc2a0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dylad
force-pushed
the
pr/tests/sys/shell/fix_ci_error_llvm
branch
2 times, most recently
from
933609a to
7931e01
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dylad
force-pushed
the
pr/tests/sys/shell/fix_ci_error_llvm
branch
from
7931e01 to
6d79fc6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: dylad <[email protected]>
dylad
force-pushed
the
pr/tests/sys/shell/fix_ci_error_llvm
branch
from
6d79fc6 to
1a69d9c
Compare
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Increase the stack of the periodic thread which is started with the
periodiccommand oftests/sys/shell.On LLVM toolchain, the test fails as only one tick occurs. With this patch the test works as intended.
The behavior of the LLVM is unclear to me here, as it seems there is some data corruption occurring on the stack.
Testing procedure
CI catches this, so let's run the test on CI once again.
Issues/PRs references
See CI tests