Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp8266: fix doxygen unbalanced grouping #20567

Merged
merged 3 commits into from
Apr 16, 2024
Merged

cpu/esp8266: fix doxygen unbalanced grouping #20567

merged 3 commits into from
Apr 16, 2024

Conversation

krzysztof-cabaj
Copy link
Contributor

@krzysztof-cabaj krzysztof-cabaj commented Apr 11, 2024 •
edited
Loading

Contribution description

During working on PR #20556 I observe in the make doc output error:

.../RIOT/cpu/esp8266/include/periph_cpu.h:335: warning: end of file with unbalanced grouping commands

This PR fix it.

Testing procedure

Execute make doc and observe output - with this PR mentioned error did not appear.

Issues/PRs references

None

@github-actions github-actions bot added Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports labels Apr 11, 2024
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 12, 2024
@riot-ci
Copy link

riot-ci commented Apr 12, 2024 •
edited
Loading

Murdock results

✔️ PASSED

8eb4e6a dist/tools/doccheck: do not ignore unbalanced groups

Success Failures Total Runtime
1 0 1 01m:01s

Artifacts

@kfessel kfessel mentioned this pull request Apr 15, 2024
Closed
@kfessel
Copy link
Contributor

kfessel commented Apr 15, 2024

@krzysztof-cabaj if you like you can integrate #20578

@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Apr 15, 2024
@krzysztof-cabaj
Copy link
Contributor Author

@kfessel I chery-picked your commit 59cfce5f59089c8f01f139b9a962bbeaf769ee0a - you think about such integration?

@benpicco benpicco enabled auto-merge April 15, 2024 19:01
@benpicco benpicco added this pull request to the merge queue Apr 15, 2024
@maribu maribu removed this pull request from the merge queue due to a manual request Apr 16, 2024
@maribu maribu added this pull request to the merge queue Apr 16, 2024
Merged via the queue into RIOT-OS:master with commit 0391458 Apr 16, 2024
25 checks passed
@mguetschow mguetschow added this to the Release 2024.07 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ESP Platform: This PR/issue effects ESP-based platforms
Projects
None yet
Milestone
Release 2024.07
Development

Successfully merging this pull request may close these issues.
6 participants
@krzysztof-cabaj @riot-ci @kfessel @benpicco @maribu @mguetschow