Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/shell/cmds: add cat and tee cmds #20568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Enoch247
Copy link
Contributor

Contribution description

This patch moves these shell cmds out of the filesystem example into the shell cmds folder. This is done to make them available to all applications.

Testing procedure

  • run make -C examples/filesystem all term
  • run help
  • observe that cat and tee commands are present

Issues/PRs references

none known

This patch moves these shell cmds out of the filesystem example into the
shell cmds folder. This is done to make them available to all
applications.
@github-actions github-actions bot added Area: build system Area: Build system Area: sys Area: System Area: examples Area: Example Applications labels Apr 12, 2024
@Enoch247
Copy link
Contributor Author

Since I simply moved these commands, and did not write them, I copied the copyright and author info from the file they originally came from. I checked the git history to verify the author. Is it okay for me to assign a copyright to somebody else?

@Enoch247
Copy link
Contributor Author

I am wondering if the tee cmd should be renamed to something else. It doesn't really behave much like the *nix tee cmd, which would be a source of confusion for most users. Or maybe just drop it all together?

*/

#include <stdio.h>
/*#include <string.h>*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's going on here?

@maribu maribu requested a review from benpicco May 1, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: examples Area: Example Applications Area: sys Area: System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants