cpu/msp430/periph_timer: add a static_assert() for clear mask #20571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Platform: MSP
github-actions
bot
added
Area: cpu
The driver assumes that timer A and timer B have the same register layout regarding all the features exposed by the driver. This is backed by the MCU family datasheets for the MSP430 x1xx and the MSP430 G2xx / F2xx MCUs (and likely more families). The assert() is pretty limited in coverage, but more to document why a "timer A clear" mask is used but still claiming the driver also works for timer B. It just looks too much like a bug otherwise.
maribu
force-pushed
the
cpu/msp430/timer
branch
from
2ef9491 to
49d59d1
Compare
Teufelchen1
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The driver assumes that timer A and timer B have the same register layout regarding all the features exposed by the driver. This is backed by the MCU family datasheets for the MSP430 x1xx and the MSP430 G2xx / F2xx MCUs (and likely more families).
The assert() is pretty limited in coverage, but more to document why a "timer A clear" mask is used but still claiming the driver also works for timer B. It just looks too much like a bug otherwise.
Testing procedure
Green CI.
Issues/PRs references
None