cpu/msp430/periph_timer: fix timer_query_freqs() [backport 2024.04] #20580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`timer_query_freqs()` should return 0 when index is out of range according to the doc. This changes the code to live up to the spec. (cherry picked from commit 5adf1f1)
Also test that `timer_query_freqs()` for an index out of range does return 0, as stated by the doc. (cherry picked from commit 189bb29)
maribu
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
maribu
added
Area: cpu
maribu
added
the
CI: ready for build
maribu
added
Impact: minor
|
@Teufelchen1 This one includes the increase of the test coverage by adding an Can I keep that commit in the backport anyway, pretty-please? |
Teufelchen1
approved these changes
Apr 23, 2024
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20574
Contribution description
The API doc for
timer_query_freqs()says it should return 0 Hz as frequency when the prescaler index is out of range. This changes the MSP430 timer driver to live up to the spec.It also sneaks in an extension to the test app, so that in the future offending code is more easily detected.
Testing procedure
Run the new test. It should pass with this PR, but would fail on master (when the next test is backported).
Issues/PRs references
None