Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/olimex-msp430-h2618: fix ztimer config [backport 2024.04] #20583

Conversation

maribu
Copy link
Member

@maribu maribu commented Apr 15, 2024

Backport of #20575

Contribution description

The MSP430 timer prescaler can device the 16 MHz clock down to (16 / 2^x) MHz, with 0 <= x < 4. So no slower than 2 MHz.

With the current ztimer config the clock would run at twice the speed.

Testing procedure

The tests wouldn't really catch this, but the datasheet and the test in tests/periph/timer can confirm that it gets no slower than 2 MHz with a 16 MHz subsystem main clock.

Issues/PRs references

None

@maribu maribu added Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Apr 15, 2024
@riot-ci
Copy link

riot-ci commented Apr 15, 2024

Murdock results

✔️ PASSED

5f4f149 boards/olimex-msp430-h2618: fix ztimer config

Success Failures Total Runtime
354 0 354 02m:26s

Artifacts

The MSP430 timer prescaler can device the 16 MHz clock down to
(16 / 2^x) MHz, with 0 <= x < 4. So no slower than 2 MHz.

With the current ztimer config the clock would run at twice the speed.

(cherry picked from commit 43fa3bc)
@maribu maribu force-pushed the backport/2024.04/boards/olimex-msp430-h2618/ztimer branch from 20f6fb4 to 5f4f149 Compare April 22, 2024 13:06
@Teufelchen1 Teufelchen1 enabled auto-merge April 23, 2024 11:48
@Teufelchen1 Teufelchen1 added this pull request to the merge queue Apr 23, 2024
Merged via the queue into RIOT-OS:2024.04-branch with commit 528dc3c Apr 23, 2024
26 checks passed
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
@mguetschow mguetschow modified the milestones: Release 2024.04, Release 2024.07 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants