Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver/mtd_spi_nor, pkg/littlefs: improve reliability with corrupted flash (new PR) #20589

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open
51 changes: 48 additions & 3 deletions drivers/include/mtd_spi_nor.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,29 @@
* @ingroup drivers_storage
* @brief Driver for serial NOR flash memory technology devices attached via SPI
*
* @{
*
* @section mtd_spi_nor_overview Overview
* Various manufacturers such as ISSI or Macronix offer small SPI NOR Flash which usually
* come in 8-pin packages and are used for persistent data storage.
* This driver adds support for these devices with support for RIOT's MTD subsystem.
*
* @section mtd_spi_nor_usage Usage
*
* The basic functions of all flash devices can be used by just including the
* mtd_spi_nor module.
*
* USEMODULE += mtd_spi_nor
*
* For ISSI and Macronix devices, some data integrity features are provided
* to check if program or erase operations were successful.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like something where we could also have a software fallback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, however reading back all the data that was written previously or doing a blank check after an erase operation would lead to a significant performance penalty.

That is something I would prefer to do in a second PR, separate from this.

* These features can be activated by specifying the "SPI_NOR_F_CHECK_INTEGRITY" flag in
* the "flag" parameter of the mtd_spi_nor_params_t structure.
*
* \n
* Some examples of how to work with the MTD SPI NOR driver can be found in the test for the
* driver or in some board definitions such as for the nRF52840DK.
*
* @{
* @file
* @brief Interface definition for the serial flash memory driver
*
Expand All @@ -30,6 +51,7 @@
#include "periph/spi.h"
#include "periph/gpio.h"
#include "mtd.h"
#include "kernel_defines.h"

#ifdef __cplusplus
extern "C"
Expand All @@ -38,6 +60,9 @@ extern "C"

/**
* @brief SPI NOR flash opcode table
*
* Manufacturer specific opcodes have a short form of the manufacturer as a prefix,
* for example "MX" for "Macronix".
*/
typedef struct {
uint8_t rdid; /**< Read identification (JEDEC ID) */
Expand All @@ -53,7 +78,10 @@ typedef struct {
uint8_t chip_erase; /**< Chip erase */
uint8_t sleep; /**< Deep power down */
uint8_t wake; /**< Release from deep power down */
/* TODO: enter 4 byte address mode for large memories */
uint8_t mx_rdscur; /**< Read security register (Macronix specific) */
uint8_t issi_rderp; /**< Read extended read parameters register (ISSI specific) */
uint8_t issi_clerp; /**< Clear extended read parameters register (ISSI specific) */
uint8_t issi_wrdi; /**< Write disable (ISSI specific) */
} mtd_spi_nor_opcode_t;

/**
Expand Down Expand Up @@ -96,6 +124,22 @@ typedef struct __attribute__((packed)) {
*/
#define SPI_NOR_F_SECT_64K (4)

/**
* @brief Enable data integrity checks after program/erase operations
* for devices that support it.
*/
#define SPI_NOR_F_CHECK_INTEGRETY (256)

/**
* @brief Enable functionality that is specific for Macronix devices.
*/
#define SPI_NOR_F_MANUF_MACRONIX (0xC2)

/**
* @brief Enable functionality that is specific for ISSI devices.
*/
#define SPI_NOR_F_MANUF_ISSI (0x9D)

/**
* @brief Compile-time parameters for a serial flash device
*/
Expand Down Expand Up @@ -170,7 +214,8 @@ extern const mtd_desc_t mtd_spi_nor_driver;
* The numbers were taken from Micron M25P16, but the same opcodes can
* be found in Macronix MX25L25735E, and multiple other data sheets for
* different devices, as well as in the Linux kernel, so they seem quite
* sensible for default values. */
* sensible for default values.
*/
extern const mtd_spi_nor_opcode_t mtd_spi_nor_opcode_default;

/**
Expand Down
230 changes: 230 additions & 0 deletions drivers/mtd_spi_nor/include/mtd_spi_nor_defines.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,230 @@
/*
* Copyright (C) 2024 Technische Universität Hamburg
*
* This file is subject to the terms and conditions of the GNU Lesser General
* Public License v2.1. See the file LICENSE in the top level directory for more
* details.
*/

/**
* @ingroup drivers_mtd_spi_nor
* @{
*
* @file
* @brief Definitions for the MTD SPI NOR Flash driver
*
* @author Christopher Büchse <[email protected]>
*
*/

#ifndef MTD_SPI_NOR_DEFINES_H
#define MTD_SPI_NOR_DEFINES_H

#ifdef __cplusplus
extern "C" {
#endif

/**
* @name Common Status Bits from the Status Register of SPI NOR Flashs
* @{
*/
/**
* @brief Write In Progress Flag (R)
*
* 0 - Device is ready
* 1 - Write cycle in progress and device is busy
*/
#define SPI_NOR_STATUS_WIP 0x01u

/**
* @brief Write Enable Latch Flag (R/W)
*
* 0 - Device is not write enabled
* 1 - Device is write enabled
*/
#define SPI_NOR_STATUS_WEL 0x02u

/**
* @brief Block Protection Bit 0 Flag (R/W)
*
* 0 - Specific blocks are not write-protected
* 1 - Specific blocks are write-protected
*/
#define SPI_NOR_STATUS_BP0 0x04u

/**
* @brief Block Protection Bit 1 Flag (R/W)
*
* 0 - Specific blocks are not write-protected
* 1 - Specific blocks are write-protected
*/
#define SPI_NOR_STATUS_BP1 0x08u

/**
* @brief Block Protection Bit 2 Flag (R/W)
*
* 0 - Specific blocks are not write-protected
* 1 - Specific blocks are write-protected
*/
#define SPI_NOR_STATUS_BP2 0x10u

/**
* @brief Block Protection Bit 3 Flag (R/W)
*
* 0 - Specific blocks are not write-protected
* 1 - Specific blocks are write-protected
*/
#define SPI_NOR_STATUS_BP3 0x20u

/**
* @brief Quad Enable Flag (R/W)
*
* 0 - Quad output function disabled
* 1 - Quad output function enabled
*/
#define SPI_NOR_STATUS_QE 0x40u

/**
* @brief Status Register Write Disable Flag (R/W)
*
* 0 - Status Register is not write protected
* 1 - Status Register is write protected
*/
#define SPI_NOR_STATUS_SRWD 0x80u

/** @} */

/**
* @name Macronix Style Security Register Bits
* @note These flags were taken from the MX25L51245G datasheet, but probably apply
* to other devices from Macronix as well.
* @{
*/
/**
* @brief Secured OTP Flag
*
* 0 - OTP area not factory locked
* 1 - OTP area factory locked
*/
#define MX_SECURITY_SOTP 0x01u

/**
* @brief Lock-down Secured OTP Flag
*
* 0 - OTP area not (user) locked
* 1 - OTP area locked (can not be programmed/erased)
*/
#define MX_SECURITY_LDSO 0x02u

/**
* @brief Program Suspend Flag
*
* 0 - Program is not suspended
* 1 - Program suspended
*/
#define MX_SECURITY_PSB 0x04u

/**
* @brief Erase Suspend Flag
*
* 0 - Erase is not suspended
* 1 - Erase is suspended
*/
#define MX_SECURITY_ESB 0x08u

/**
* @brief Reserved
*/
#define MX_SECURITY_XXXXX 0x10u

/**
* @brief Program Fail Flag
*
* 0 - Program Operation succeeded
* 1 - Program Operation failed or region is protected
*/
#define MX_SECURITY_PFAIL 0x20u

/**
* @brief Erase Fail Flag
*
* 0 - Erase Operation succeeded
* 1 - Erase Operation failed or region is protected
*/
#define MX_SECURITY_EFAIL 0x40u

/**
* @brief Write Protection Selection Flag
*
* 0 - Normal Write Protect mode
* 1 - Advanced Sector Protection mode
*/
#define MX_SECURITY_WPSEL 0x80u
/** @} */

/**
* @name ISSI Style Security Register Bits from Extended Read Register (ERP)
* @note These flags were taken from the IS25LE01G datasheet, but probably
* apply to other devices from ISSI as well.
* @{
*/

/**
* @brief Reserved
*/
#define IS_ERP_XXXXX 0x01u

/**
* @brief Protection Error Flag (R)
*
* 0 - No protection error
* 1 - Protection Error occurred in program or erase
*/
#define IS_ERP_PROT_E 0x02u

/**
* @brief Program Error Flag (R)
*
* 0 - Program Operation succeeded
* 1 - Program Operation failed or region is protected
*/
#define IS_ERP_P_ERR 0x04u

/**
* @brief Erase Error Flag (R)
*
* 0 - Erase Operation succeeded
* 1 - Erase Operation failed or region is protected
*/
#define IS_ERP_E_ERR 0x08u

/**
* @brief Data Learning Pattern Flag (R/W)
*
* 0 - DLP is disabled
* 1 - DLP is enabled
*/
#define IS_ERP_DLPEN 0x10u

/**
* @brief Output Driver Strength Bit 0 (R/W)
*/
#define IS_ERP_ODS0 0x20u

/**
* @brief Output Driver Strength Bit 1 (R/W)
*/
#define IS_ERP_ODS1 0x40u

/**
* @brief Output Driver Strength Bit 2 (R/W)
*/
#define IS_ERP_ODS2 0x80u
/** @} */

#ifdef __cplusplus
}
#endif

#endif /* MTD_SPI_NOR_DEFINES_H */
/** @} */
Loading
Loading