Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/esp: Handle format print errors #20596

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Teufelchen1
Copy link
Contributor

Contribution description

Hi 🦋

vsnprintf is not easy to use. This catches the error return and the truncation.
Not sure if my approach is good as I am lacking context knowledge for that function.

Testing procedure

I don't know.

Issues/PRs references

@Teufelchen1 Teufelchen1 requested a review from gschorcht as a code owner April 18, 2024 15:21
@github-actions github-actions bot added Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports labels Apr 18, 2024
@Teufelchen1 Teufelchen1 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 18, 2024
@riot-ci
Copy link

riot-ci commented Apr 18, 2024

Murdock results

✔️ PASSED

01e78ed cpu/esp: Handle format print errors

Success Failures Total Runtime
10066 0 10066 18m:22s

Artifacts

Copy link
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handles the vsnprintf output better than befor.

cpu/esp_common/lib_printf.c Outdated Show resolved Hide resolved
@Teufelchen1 Teufelchen1 added this pull request to the merge queue Apr 25, 2024
Merged via the queue into RIOT-OS:master with commit 925644e Apr 25, 2024
25 checks passed
@mguetschow mguetschow added this to the Release 2024.07 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants