-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/cortexm_common: make SVC call always available #20603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, didn't test it
9d087c9
to
7b79f67
Compare
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
7b79f67
to
acf9882
Compare
I didn't know |
Hey @dylad what do you need to move this forward? |
I forgot about this one ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can just give you second ACK :3
@kaspar030 Any objections here ? |
Signed-off-by: Dylan Laduranty <[email protected]>
05e8142
to
4dc8a4a
Compare
Looks like Murdock failed because this PR introduces some overhead. |
I'm starting to reconsider this. I was wrong thinking that |
That's what I get for not thinking stuff through 🥲 |
Contribution description
This PR proposes to make SVC call always available for user and thus removes the
cortexm_svc
pseudomodule.SVCall is available on all ARMvx-M architecture. This exception was used before to trigger PendSV for the sheduler. Now PendSV is triggered manually and no longer require to use SVCall.
Since the feature was provided by default for all cortexm, I think it makes sense to remove the pseudomodule and to let it hardcoded in the code.
Testing procedure
CI should be happy.
Issues/PRs references
None.