Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/doc: Explicitly warn when nRF chips are advertised as NFC supporting #20605

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Apr 21, 2024

Contribution description

The nRF family's NFC radio part implements only the tag emulation, and can neither access other tags nor do peer-to-peer mode.

Testing procedure

Look at the changed documentation.

Issues/PRs references

I'd rather not rant on about how much time I've sunk without this warning. (Yes I wrote the thingy:52 documentation myself).

@chrysn chrysn added Area: doc Area: Documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Apr 21, 2024
@chrysn chrysn requested a review from aabadie as a code owner April 21, 2024 18:19
@chrysn chrysn added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 21, 2024
@github-actions github-actions bot added the Area: boards Area: Board ports label Apr 21, 2024
@riot-ci
Copy link

riot-ci commented Apr 21, 2024

Murdock results

✔️ PASSED

169671d boards/doc: Explicitly warn when nRF chips are advertised as NFC supporting

Success Failures Total Runtime
1 0 1 01m:10s

Artifacts

@chrysn
Copy link
Member Author

chrysn commented Apr 21, 2024

Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@dylad dylad enabled auto-merge April 22, 2024 06:54
@dylad dylad added this pull request to the merge queue Apr 22, 2024
Merged via the queue into RIOT-OS:master with commit 4a4101b Apr 22, 2024
29 checks passed
@chrysn chrysn deleted the nfc-warnings branch April 22, 2024 08:07
@mguetschow mguetschow added this to the Release 2024.07 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants