Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/native: fix compilation with GCC 14.1 #20722

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Jun 4, 2024

Contribution description

The first argument to calloc() is the number of members, the second the member size. This fixes an instance where the arguments where switched.

Testing procedure

Compilation with GCC 14.1 for native should work again.

Issues/PRs references

Offending code merged in #18942

The first argument to `calloc()` is the number of members, the
second the member size. This fixes an instance where the arguments
where switched.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jun 4, 2024
@maribu maribu requested a review from miri64 June 4, 2024 13:48
@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Area: cpu Area: CPU/MCU ports labels Jun 4, 2024
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Jun 4, 2024
@riot-ci
Copy link

riot-ci commented Jun 4, 2024

Murdock results

✔️ PASSED

ff3f055 cpu/native: fix compilation with GCC 14.1

Success Failures Total Runtime
1 0 1 01m:13s

Artifacts

@dylad dylad added this pull request to the merge queue Jun 4, 2024
Merged via the queue into RIOT-OS:master with commit 5668de6 Jun 4, 2024
30 checks passed
@maribu maribu deleted the cpu/native/fix-gcc-14-1 branch June 4, 2024 18:35
@maribu
Copy link
Member Author

maribu commented Jun 4, 2024

Thx :)

@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: native Platform: This PR/issue effects the native platform Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants