drivers/dose: fix poweroff #21074
Merged
drivers/dose: fix poweroff #21074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
approved these changes
Dec 12, 2024
benpicco
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
If there's no state transition within the driver, powering off (STANDBY, SLEEP) a DOSE interface might result in a deadlock. Specifically,
wait_for_state()will block forever.Note, there is (and always was) a race condition here, i.e. even if we observed the state IDLE, this might transition to RECEIVE at any time. However, this case is covered by improvements in the chunked buffer implementation (see depencencies below).
Testing procedure
Tested this on a SAME54 board.
Issues/PRs references