core/thread: error in thread.c corrected #21253
Open
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in thread_wakeup() the status of the function to be woken up is incorrectly set to TASK_RUNNING. Instead the task should be set to STATUS_PENDING here, as only sched_run() is allowed to set a task to TASK_RUNNING. - in thread_create() it is checked whether the stack is large enough, but instead of aborting the function if the stack is too small and thus preventing a buffer overflow, only a debug output is made. Return statement added - in thread_state_to_string() it is not checked whether state is within the valid range, so that in the event of an error an invalid memory address is returned, which in turn leads to further invalid memory accesses when the string is output. thread_state_to_string() is used in particular by ps(). In the case of a corrupt thread context, which often occurred in my case due to the stack size being too small, thread_state_to_string() is called with an invalid status. Other - thread_add_to_list(): Adding the task to the linked list is graphically commented (If you are interested, I also prepared this for core\lib\include\list.h and core\lib\include\clist.h)
github-actions
bot
added
the
Area: core
mguetschow
added
the
CI: ready for build
Remove Trailing Whitespace
kfessel
reviewed
Feb 28, 2025
Co-authored-by: Karl Fessel <[email protected]>
kfessel
reviewed
Feb 28, 2025
Comment on lines
+399
to
+400
| assert(state < STATUS_NUMOF); | ||
| const char *name = state_names[state]; |
There was a problem hiding this comment.
i think this is more reliable -- check for not exceeding NUMOF even if assertion are disabled
Suggested change
| assert(state < STATUS_NUMOF); | |
| const char *name = state_names[state]; | |
| const char *name = NULL; | |
| if (state < STATUS_NUMOF){ | |
| name = state_names[state]; | |
| } | |
| /* if compiling with assertions, this is an error that indicates that the table above is incomplete */ | |
| assert(name != NULL) | |
| return (name != NULL) ? name : STATE_NAME_UNKNOWN; |
There was a problem hiding this comment.
i could not add a suggestion to the unchanged code assert(name != NULL); -> i attached it to the first two lines
mguetschow
added
the
Process: needs >1 ACK
github-actions
bot
added
the
Process: missing approvals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Errors in thread.c corrected:
Other
Testing procedure
Issues/PRs references