cpu/esp32: fix bus_width in periph_sdmmc #21259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Platform: ESP
gschorcht
added
Type: bug
benpicco
approved these changes
Feb 28, 2025
|
I think a rebase is needed to get the fix from #21258 in |
gschorcht
force-pushed
the
cpu/esp32/fix_periph_sdmmc
branch
from
f4689b5 to
689883c
Compare
4 tasks
|
Tanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes a small leftover found when migrating the code to ESP-IDF v5.4 which was used for debugging during the development of
cpu/esp32/periph/sdmmc. It fixes the setting of the bus width which was hardcoded down to 1 bit by this left over.Testing procedure
Compilation has to succeed.
The fix has been tested successfully with
tests/driver/sdmmcfor:Issues/PRs references