cpu/nrf52: Update nRF52840 Vendor Header Files #21739
Open
+7,441
−5,148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crasbe
added
Type: enhancement
github-actions
bot
added
Platform: ARM
crasbe
removed
the
State: WIP
|
Thanks, that has been on my backlog for quite some time :) Would you mind updating the other nrf52 vendor files as well, while you are at it? Did you encounter any problems you had to fix manually? |
|
Sure, can do. However I only have the nRF52832 and nRF52840 for actual hardware testing. The only manual fixes were including the "name change" header and commenting out the "System" header, so it's a reasonable amount of work to do for the other microcontrollers too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
For a project we want to access some registers of the nRF52840, that are not yet specified in the current vendor files.
Nordic changed some stuff, but it appears as if most of the registers are unchanged.
Included in that "changing stuff" is a bunch of renames that actually have an effect, which is why the
nrf52840_name_change.hfile was added.
I changed the
nrf52840.hheader to not include thesystem_nrf52840.hfile (commented that line out) and added the Name Change header.The System header was not included previously either, so it shouldn't matter. Also, the System header provided by the nrfx repo was quite bare.
The nrfx version that these files come from is 3.14.0.
Testing procedure
All your favorite nRF52840 applications should still work.
Issues/PRs references
None.