boards/nrf52-based, dist/tools/jlink: fix and enhance JLINK_POST_FLASH
command
#21740
+12
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
With #20965 I added the "Pinreset Enable" functionality to RIOT for nRF52 boards by setting the right values in the UICR register after flashing.
However this had two flaws:
Makefile
instead ofMakefile.include
).The second part also involves modifying the
jlink.sh
script to evaluate multiple commands that are each put into"..."
brackets.Testing procedure
You can use an nRF52DK, nRF52840DK, DWM1001 or Waveshare-nRF52840 board for testing.
With current master, the two
ShowConf
commands are ignored and you only see the command to set the Pin Reset.With this PR, all commands are executed.
Issues/PRs references
Fixup for #20965.