-
Notifications
You must be signed in to change notification settings - Fork 2.1k
doc/guides: add riot changelog #21741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
doc/guides: add riot changelog #21741
Conversation
Huge W, Starlight giving us a really nice Changelog Reader + RSS Feed wasn't on my bingo card but I'm here for it :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool 👍
53956ae
to
b4d239d
Compare
81368aa
to
16853f8
Compare
d4dadcf
to
3e36792
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤓☝️ A few more suggestions, but nice work on the loader, very elegant
I think with the Doxygen version of that I just added a regex, that bumped down all headers one level as a pre-filter. |
Ok, must have been a different script (just took a look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐸 One More Time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🉑 🤠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you :)
Ready for review :) |
Okay a small fix to the comments, but now it is ready |
There was a small mistake after my rewrite of the content collection generation yesterday, which resulted in the latest changelog not being visible. This is fixed now. |
I added a schema to improve type safety. |
doc/starlight/src/content.config.ts
Outdated
// Convert all headings to be one level lower | ||
// h1 => h2, h2 => h3, h3 => h4 | ||
// This is necessary, because the heading levels of this file are wrong (for markdown) | ||
// We cannot have more than one h1 per document etc. | ||
// Check if next line contains only "=" characters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there maybe be a general s/^(#)+/#\1/g
(regex substitution for “add a #
before every line that starts with a #
”) before all this in case future release notes include deeper nesting than h3
? (also I don't see any h4
/####
in the current code which would also be covered by this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes true so a better solution is to first convert the heading style to #
based headings and then in general increase each #
heading by one level?
This way we will also be compatible with higher heading nesting in the future and will also support converting #
headings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ;)
Contribution description
Added the changelog of riot releases to the guide page and deprecated the doxygen page
Nice cool new fetures:
Screenshots