Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove echo=False #9744

Merged
merged 5 commits into from
Aug 9, 2018

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Aug 9, 2018

Contribution description

All tests should be run with an output by default.

Issues/PRs references

No output for successful tests when building tests in native in release tests.

RIOT-OS/Release-Specs#69 (comment)

@cladmi cladmi added Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Aug 9, 2018
@cladmi cladmi added this to the Release 2018.07 milestone Aug 9, 2018
@cladmi cladmi requested a review from aabadie August 9, 2018 05:16
@miri64
Copy link
Member

miri64 commented Aug 9, 2018

Mh, is it necessarily a bad thing to have no output for successful tests? If they are successful, what do you get from the extra information?

@cladmi
Copy link
Contributor Author

cladmi commented Aug 9, 2018

It does not print information on failure too. I just found about it because it was not printed on success.

On IoT-LAB M3 for cbor, I first thought it crashed at the beginning:

tests/01-run.py
Timeout in expect script at "child.expect_exact('(uint64_t, 1)')" (tests/cbor/tests/01-run.py:17)

Makefile:24: recipe for target 'test' failed
make: *** [test] Error 1

Whit echo=True:

2018-08-09 12:06:00,283 - INFO # �main(): This is RIOT! (Version: buildtest)
2018-08-09 12:06:00,287 - INFO # Data:
2018-08-09 12:06:00,288 - INFO # (uint64_t, lu)
2018-08-09 12:06:00,288 - INFO # (uint64_t, lu)
2018-08-09 12:06:00,289 - INFO # (uint64_t, lu)
2018-08-09 12:06:00,289 - INFO # (int64_t, ld)
2018-08-09 12:06:00,290 - INFO # (bool, 1)
2018-08-09 12:06:00,290 - INFO # (float, )
2018-08-09 12:06:00,291 - INFO # (float, )
2018-08-09 12:06:00,291 - INFO # (double, )
2018-08-09 12:06:00,292 - INFO # (byte string, "abc")
2018-08-09 12:06:00,292 - INFO # (unicode string, "def")
2018-08-09 12:06:00,293 - INFO # (array, length: lu)
2018-08-09 12:06:00,293 - INFO #   (uint64_t, lu)
2018-08-09 12:06:00,294 - INFO #   (uint64_t, lu)
2018-08-09 12:06:00,295 - INFO # (array, length: [indefinite])
2018-08-09 12:06:00,295 - INFO #   (uint64_t, lu)
2018-08-09 12:06:00,296 - INFO #   (uint64_t, lu)
2018-08-09 12:06:00,296 - INFO # (map, length: lu)
2018-08-09 12:06:00,297 - INFO #  (uint64_t, lu)
2018-08-09 12:06:00,297 - INFO #   (byte string, "1")
2018-08-09 12:06:00,298 - INFO #  (uint64_t, lu)
2018-08-09 12:06:00,298 - INFO #   (byte string, "2")
2018-08-09 12:06:00,299 - INFO # (map, length: [indefinite])
2018-08-09 12:06:00,300 - INFO #  (uint64_t, lu)
2018-08-09 12:06:00,300 - INFO #   (byte string, "10")
2018-08-09 12:06:00,301 - INFO #  (uint64_t, lu)
2018-08-09 12:06:00,301 - INFO #   (byte string, "11")
2018-08-09 12:06:00,302 - INFO # 
2018-08-09 12:06:00,302 - INFO # Context before hardfault:
2018-08-09 12:06:00,303 - INFO #    r0: 0x595b0025
2018-08-09 12:06:00,303 - INFO #    r1: 0x08006a4c
2018-08-09 12:06:00,304 - INFO #    r2: 0x200007cc
2018-08-09 12:06:00,304 - INFO #    r3: 0x200002ea
2018-08-09 12:06:00,305 - INFO #   r12: 0x20000763
2018-08-09 12:06:00,306 - INFO #    lr: 0x08003be5
2018-08-09 12:06:00,306 - INFO #    pc: 0x08003be6
2018-08-09 12:06:00,307 - INFO #   psr: 0x21000000
2018-08-09 12:06:00,307 - INFO # 
2018-08-09 12:06:00,307 - INFO # FSR/FAR:
2018-08-09 12:06:00,308 - INFO #  CFSR: 0x00008200
2018-08-09 12:06:00,308 - INFO #  HFSR: 0x40000000
2018-08-09 12:06:00,309 - INFO #  DFSR: 0x00000000
2018-08-09 12:06:00,309 - INFO #  AFSR: 0x00000000
2018-08-09 12:06:00,310 - INFO #  BFAR: 0x595b0026
2018-08-09 12:06:00,310 - INFO # Misc
2018-08-09 12:06:00,311 - INFO # EXC_RET: 0xfffffffd
2018-08-09 12:06:00,312 - INFO # Attempting to reconstruct state for debugging...
2018-08-09 12:06:00,312 - INFO # In GDB:
2018-08-09 12:06:00,313 - INFO #   set $pc=0x8003be6
2018-08-09 12:06:00,313 - INFO #   frame 0
2018-08-09 12:06:00,313 - INFO #   bt
2018-08-09 12:06:00,314 - INFO # 
2018-08-09 12:06:00,314 - INFO # ISR stack overflowed by at least 16 bytes.
Timeout in expect script at "child.expect_exact('(uint64_t, 1)')" (tests/cbor/tests/01-run.py:17)

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I get your point. That might be confusing. ACK

@miri64 miri64 merged commit 8966f01 into RIOT-OS:master Aug 9, 2018
@cladmi
Copy link
Contributor Author

cladmi commented Aug 9, 2018

Backport provided in #9749

@cladmi
Copy link
Contributor Author

cladmi commented Aug 9, 2018

Backport provided in #9750

@miri64
Copy link
Member

miri64 commented Aug 9, 2018

(#9749 was closed accidentally)

@cladmi cladmi deleted the pr/tests/run_all_with_echo_true branch August 9, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants