Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add merge group CI_BASE_BRANCH/COMMIT extraction #49

Merged
merged 1 commit into from
Nov 9, 2023
Merged

add merge group CI_BASE_BRANCH/COMMIT extraction #49

merged 1 commit into from
Nov 9, 2023

Conversation

kaspar030
Copy link
Contributor

No description provided.

@kaspar030
Copy link
Contributor Author

I've deployed this to latest-staging, testing now.

@kaspar030 kaspar030 force-pushed the add_merge_group_support branch from 63d36bf to 8855e57 Compare November 9, 2023 10:04
@kaspar030
Copy link
Contributor Author

seems to not break anything, and the info is extracted properly.
here's a merge_group build: https://ci-staging.riot-os.org/details/325300c6e415461e8d75df0d6051d9f5/output
here's a non merge_group build: https://ci-staging.riot-os.org/details/7308581f2a4e45c28b03978acf7076ca/output

@kaspar030
Copy link
Contributor Author

@MrKevinWeiss @aabadie do you think you could ACK this?

MrKevinWeiss
MrKevinWeiss approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a solution so let's try it!

@kaspar030 kaspar030 merged commit f0aae16 into RIOT-OS:master Nov 9, 2023
1 check passed
@kaspar030 kaspar030 deleted the add_merge_group_support branch November 9, 2023 10:17
This was referenced Nov 9, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaspar030 @MrKevinWeiss