build.sh: Set RIOTBASE when running make #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all of make works fine without RIOTBASE, but RIOTBOARD is not set correctly without it.
|
Hmpf, there are multiple breakages, some may need proper fixing in build scripts... |
|
Turns out the actual culprit was murdock zeroing out BOARDS, which not only affects what it is supposed to affect (what is that, really?) but also curbs RIOT's ability to reflect on which boards it has. (Funnily it worked in ci-staging because BOARDS is apparently set to a small list there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all of make works fine without RIOTBASE, but RIOTBOARD is not set correctly without it.
We could go try figure out how to make our make processes more resilient, but at this point I'm sufficiently deep in debugging to just call them brittle and acknowledge that application Makefiles just set RIOTBASE and that top-level make is typically called just from there.