Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin down scipy version #234

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Oct 12, 2023

Newer versions cause build failures because they expect a newer cython than is provided in jammy; they'd show errors like:

      Error compiling Cython file:
      ------------------------------------------------------------
      ...
      ctypedef float s                                                                                                                             ctypedef double d                                                                                                                            ctypedef float complex c
      ctypedef double complex z
      cdef void caxpy(int *n, c *ca, c *cx, int *incx, c *cy, int *incy) noexcept nogil
                                                                        ^
      ------------------------------------------------------------

      /usr/local/lib/python3.10/dist-packages/scipy/linalg/cython_blas.pxd:20:67: Syntax error in C variable declaration

Let's hope this allows building again -- if not, we have multiple bitrots to combat.

Newer versions cause build failures because they expect a newer cython
than is provided in jammy; they'd show errors like:

```
      Error compiling Cython file:
      ------------------------------------------------------------
      ...
      ctypedef float s                                                                                                                             ctypedef double d                                                                                                                            ctypedef float complex c
      ctypedef double complex z
      cdef void caxpy(int *n, c *ca, c *cx, int *incx, c *cy, int *incy) noexcept nogil
                                                                        ^
      ------------------------------------------------------------

      /usr/local/lib/python3.10/dist-packages/scipy/linalg/cython_blas.pxd:20:67: Syntax error in C variable declaration
```
@chrysn
Copy link
Member Author

chrysn commented Oct 12, 2023

For context, I also tested 1.9.0 (installation worked); at the time of filing this, 1.11.3 is current, which broke in the way described above. I didn't easily find when scipy changed its cython requirements, but it'd stand to versioning reason they'd only do that as part of at least the minor 1.11 release, and 1.10.1 is currently the last of the 1.10s. (Could probably do this more sharply as < 1.11, but we've been burnt enough here already, and I don't think that there will be security updates for scipy 1.10).

@chrysn
Copy link
Member Author

chrysn commented Oct 12, 2023

Thanks. We're not even in hard freeze, so I think I can just go:

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 12, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

  • Build and Test

@bors bors bot merged commit 3137389 into RIOT-OS:master Oct 12, 2023
@chrysn chrysn deleted the mitigate-new-scipy branch October 12, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants