Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riotbuild: add libsdl2-dev:amd64 #241

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

fzi-haxel
Copy link
Contributor

Adds the 64-bit version of libsdl2-dev required for the 64-bit version of native.
Needed in RIOT-OS/RIOT#20335

libsdl2-dev has quite a few dependencies and adds about 190MB to the image.
If this is too much, I could also blacklist tests_lvgl and tests_lvgl_touch for the CI.

@benpicco
Copy link
Contributor

benpicco commented Feb 3, 2024

Arg, I think the problem is that the libsdl2-dev:i386 package conflicts with libsdl2-dev 😕

@fzi-haxel
Copy link
Contributor Author

fzi-haxel commented Feb 3, 2024

Arg, I think the problem is that the libsdl2-dev:i386 package conflicts with libsdl2-dev 😕

Mh, apt does not complain about installing libsdl2-dev, but the rust build test fails. I'm not sure if they are related.
I tried building the image locally and for me the rust test and the native64 lvgl test worked.

@fzi-haxel
Copy link
Contributor Author

Re-running the build doesn't seem to fix it. I will try to reproduce the problem on Monday. Maybe it's because I didn't build the base images.

@chrysn
Copy link
Member

chrysn commented Feb 5, 2024

I'm adding another re-run here. This kind of error (fatal error: 'preprocessor_successor.h' file not found) has been seen occasionally, but never was stable enough to be really reproduced; chances are it's going away now that I'm looking at it with 2 days time passed :-/

@chrysn
Copy link
Member

chrysn commented Feb 5, 2024

Failed again. Retrying master to verify my assumption that this is a failure unrelated to the content of this PR.

@kaspar030
Copy link
Contributor

Failed again. Retrying master to verify my assumption that this is a failure unrelated to the content of this PR.

I've seen this a couple of times in this repo, usually some retries make CI pass.

@kaspar030
Copy link
Contributor

I've opened an issue. It's probably a race in the riot repo that somehow shows here more often.

@chrysn
Copy link
Member

chrysn commented Feb 7, 2024

Please rebase onto #246 (or master once that is in), that should make the problem go away.

@fzi-haxel fzi-haxel force-pushed the pr/libsdl2-dev-amd64 branch from 0b68228 to f20fc20 Compare February 8, 2024 08:25
@fzi-haxel
Copy link
Contributor Author

Please rebase onto #246 (or master once that is in), that should make the problem go away.

Rebased on master

@chrysn
Copy link
Member

chrysn commented Aug 28, 2024

Still looks good to me (can't merge due to permission troubles), but one clarification might be due anyway: This was described as blocking RIOT-OS/RIOT#20335, but that is now through. Is this still an issue (and 20335 just had a workaround that can be dropped once this is through), or has this one become moot?

@fzi-haxel
Copy link
Contributor Author

Still looks good to me (can't merge due to permission troubles), but one clarification might be due anyway: This was described as blocking RIOT-OS/RIOT#20335, but that is now through. Is this still an issue (and 20335 just had a workaround that can be dropped once this is through), or has this one become moot?

RIOT-OS/RIOT#20335 was a larger PR. benpicco recommended to blacklist native64 for the lvgl tests in order not to block the CI until this issue has been resolved.

If this PR is merged, we should be able to remove these lines in RIOT and run the tests in the CI:

@benpicco benpicco added this pull request to the merge queue Aug 28, 2024
Merged via the queue into RIOT-OS:master with commit 34bc4ab Aug 28, 2024
1 check passed
@benpicco
Copy link
Contributor

I remember when it wasn't possible to install both the 32 bit and the 64 bit version of libsdl2-dev in parallel - either that changed or our CI doesn't catch it.

@fzi-haxel
Copy link
Contributor Author

I remember when it wasn't possible to install both the 32 bit and the 64 bit version of libsdl2-dev in parallel - either that changed or our CI doesn't catch it.

I think the reason this build (and some others) failed was fixed in #246. The current docker image has both versions installed, and a quick test of tests/pkg/lvgl with the docker image seems to work for both native and native64.
(After increasing LV_MEM_SIZE for native64, which seems to be too small for 64bit.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants