CI: Run on main and on request in addition to pull requests #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
force-pushed
the
run-on-main
branch
7 times, most recently
from
fee80a4 to
81cbc1f
Compare
The largest amount of time is the machine checkout -- 2 minutes. The 7 seconds of `cargo update` are dwarved by that, and running in parallel means we don't have to eat those 2 minutes twice. (Also, I couldn't figure out how to carry the output state of the `needs`'d preparations over to the actual working steps).
|
This also fixes what originally caused me to look into the CI again: not all tests sitting in tests/* any more (but the tests relied on everything in there to be a test) |
chrysn
force-pushed
the
run-on-main
branch
4 times, most recently
from
599f8a6 to
a6fb1eb
Compare
…lacks their prerequisites
chrysn
force-pushed
the
run-on-main
branch
2 times, most recently
from
6b8d417 to
db3bc63
Compare
... because the test running clause would not test on its own and fail on missing feature requirements
At least with the current GitHub versions, ::echo ::on doesn't do anything.
(But not enabling RIOT_CI_BUILD b/c we're not inside a Murdock run, and who knows what else that flag enables.)
Workaround-For: RIOT-OS/RIOT#20110
chrysn
force-pushed
the
run-on-main
branch
3 times, most recently
from
02acff8 to
95b6a23
Compare
Some Makefile are for tools inside tests
chrysn
added a commit
that referenced
this pull request
Dec 2, 2023
The tests are now run using individual steps for the same reasons the examples were switched over. In [68], the tests were accidentally switched over to running all RIOT instead of all own tests (which may also make sense but is really excessive, and most importantly lost the own tests) [68]: #68
chrysn
added a commit
that referenced
this pull request
Dec 2, 2023
The tests are now run using individual steps for the same reasons the examples were switched over. In [68], the tests were accidentally switched over to running all RIOT instead of all own tests (which may also make sense but is really excessive, and most importantly lost the own tests) [68]: #68
chrysn
added a commit
that referenced
this pull request
Dec 2, 2023
The tests are now run using individual steps for the same reasons the examples were switched over. In [68], the tests were accidentally switched over to running all RIOT instead of all own tests (which may also make sense but is really excessive, and most importantly lost the own tests) [68]: #68
chrysn
added a commit
that referenced
this pull request
Dec 2, 2023
The tests are now run using individual steps for the same reasons the examples were switched over. In [68], the tests were accidentally switched over to running all RIOT instead of all own tests (which may also make sense but is really excessive, and most importantly lost the own tests) [68]: #68
chrysn
added a commit
that referenced
this pull request
Dec 2, 2023
The tests are now run using individual steps for the same reasons the examples were switched over. In [68], the tests were accidentally switched over to running all RIOT instead of all own tests (which may also make sense but is really excessive, and most importantly lost the own tests) [68]: #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CI errors show up, it's always helpful to be able to look at (or re-run) the last merged state for comparison.