Discard malformed packets.

RIPE-NCC · Sep 2, 2014 · 3d1d30a · 3d1d30a
1 parent 036700c
commit 3d1d30a
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/hadoop-pcap-lib/src/main/java/net/ripe/hadoop/pcap/PcapReader.java b/hadoop-pcap-lib/src/main/java/net/ripe/hadoop/pcap/PcapReader.java
@@ -411,6 +411,10 @@ private byte[] buildTcpAndUdpPacket(Packet packet, byte[] packetData, int ipProt
 	 * @return payload as byte[]
 	 */
 	protected byte[] readPayload(byte[] packetData, int payloadDataStart, int payloadLength) {
+		if (payloadLength < 0) {
+			LOG.warn("Malformed packet - negative payload length. Returning empty payload.");
+			return new byte[0];
+		}
 		if (payloadDataStart > packetData.length) {
 			LOG.warn("Payload start (" + payloadDataStart + ") is larger than packet data (" + packetData.length + "). Returning empty payload.");
 			return new byte[0];