Add String representations for object types. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lolepezy
commented
May 10, 2022
lolepezy
commented
- I have updated the changelog in README.md
src/main/java/net/ripe/rpki/commons/util/RepositoryObjectType.java
Outdated
Show resolved
Hide resolved
erikrozendaal
approved these changes
May 10, 2022
ties
reviewed
May 10, 2022
| Crl("crl"), | ||
| Gbr("gbr"), | ||
| Aspa("asa"), | ||
| Unknown("unknown"); |
There was a problem hiding this comment.
I like having a mapping between the IANA registry and strings somewhere, hhis one is a hard one since it does not map to the registry.
Maybe we can just use the name of the enum, or the extension, instead?
There was a problem hiding this comment.
Maybe we can just use the name of the enum, or the extension, instead?
What do you mean?
There was a problem hiding this comment.
If we do not use the value internally, I expected most uses to also be able to just use the .name() of the enum. But if we use it internally here as well it makes sense.
wibisono
approved these changes
Jun 16, 2022
|
Merging this: This would have prevented a bug I had |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.