Relation Searches Endpoint #1603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelAHM
requested review from
eshryane,
fmurodov,
isvonja and
maggarwal13
as code owners
|
Code scanning results / CodeQL is throwing an issue not related with this PR. It is scanning the class and complaining about a regex that exist already in master. I created a task in the backlog to look into it. |
MiguelAHM
commented
Dec 18, 2024
whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapRelationService.java
Outdated
Show resolved
Hide resolved
MiguelAHM
commented
Dec 18, 2024
whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapRelationService.java
Outdated
Show resolved
Hide resolved
MiguelAHM
commented
Dec 18, 2024
whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapRelationService.java
Show resolved
Hide resolved
MiguelAHM
commented
Dec 18, 2024
whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapRelationService.java
Outdated
Show resolved
Hide resolved
MiguelAHM
commented
Dec 18, 2024
whois-api/src/test/java/net/ripe/db/whois/api/rdap/RdapServiceTestIntegration.java
Show resolved
Hide resolved
MiguelAHM
commented
Dec 18, 2024
whois-api/src/test/java/net/ripe/db/whois/api/rdap/RdapServiceTestIntegration.java
Show resolved
Hide resolved
MiguelAHM
commented
Dec 18, 2024
whois-api/src/test/java/net/ripe/db/whois/api/rdap/RdapServiceTestIntegration.java
Show resolved
Hide resolved
MiguelAHM
commented
Dec 18, 2024
whois-rpsl/src/main/java/net/ripe/db/whois/common/rpsl/attrs/Inet6numStatus.java
Outdated
Show resolved
Hide resolved
MiguelAHM
commented
Dec 18, 2024
whois-rpsl/src/main/java/net/ripe/db/whois/common/rpsl/attrs/InetnumStatus.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is just for doing the controller changes.
Link relation and Extensions are not contemplated in this PR
Bottom relation pseudocode in the Jira
The status query parameter is not implemented until we have implemented administrative status task:
When status is there and inactive we should return the in region administrative resources.
In case status is active we should return non administrative in region resources.
For now just always return active resource. Ignore status query parameter. (added a TODO)
We follow the points addressed in https://datatracker.ietf.org/doc/draft-ietf-regext-rdap-rir-search/ RFC