-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RDAP Relation extension #1608
Open
MiguelAHM
wants to merge
25
commits into
master
Choose a base branch
from
DB-5911-add-RDAP-relation-extension
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0116abd
feat: create controller
MiguelAHM cf6bcc6
feat: rdap Relation endpoint and ITs
MiguelAHM 387c40b
feat: fix bottom to match the RFC
MiguelAHM 4cbd0be
feat: remove unecessary changes and fix typo
MiguelAHM 32ca759
feat: add more ITs
MiguelAHM 243efbb
feat: remove unecessary changes
MiguelAHM dabd4d5
Merge branch 'master' into DB-5889-relation-searches-endpoints
MiguelAHM 68a345a
feat: enable status query parameter
MiguelAHM 8073771
feat: add Integration tests for status query parameter
MiguelAHM 4b687b7
feat: add test for status active
MiguelAHM 9ae6dd2
feat: add redirect, and TODOS
MiguelAHM ed3514d
feat: remove import
MiguelAHM 152d79d
feat: add relation conformances
MiguelAHM 081c654
feat: add its for relations
MiguelAHM c1dc87f
feat: add an IT for export database tests and include dummy object in…
MiguelAHM a8f140a
feat: nrtmv4 snapshot should create dummy object
MiguelAHM ea996d3
Revert "feat: add an IT for export database tests and include dummy o…
MiguelAHM 62355f2
Revert "feat: nrtmv4 snapshot should create dummy object"
MiguelAHM 0b4f644
feat: remove non related changes
MiguelAHM 01ba51d
Merge branch 'master' into DB-5911-add-RDAP-relation-extension
MiguelAHM 6edef97
Merge branch 'master' into DB-5911-add-RDAP-relation-extension
MiguelAHM 3986cd8
feat: renaming methods
MiguelAHM a51ec19
Merge branch 'master' into DB-5911-add-RDAP-relation-extension
eshryane 3ac8ed2
feat: fix conflicts
MiguelAHM 147334a
feat: unecessary changes
MiguelAHM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conformance should be included if it is a RIR search ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Jira says
"Always return the "rirSearch1" extension on all responses."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that is the case we should add all conformance to every rdap response but we do not. For ex: we add geofeed Conformance only if it is Ip request . I think we need to be consistent about it. Let's discuss it with Ed