-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FWT-11 #2 hallelujah effect sensor #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Oleg very cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comment changes but I don't wanna rereview so I trust you'll do them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more to do
will need to redo as I require a GPIO IRQ Handler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments 🐸 🐸 🐸
…work in isolation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just a few changes. Please remove the cmake-build-debug directory and make sure your build directory is set to 'build' in the CMAKE options. Also please update the README to describe the purpose of this repository. Also include the target device and the name of the main board target (REV3-WSS).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of nitpicks, but the overall structure is pretty good.
Also, be sure to test this thoroughly. This driver is written assuming that we'll be able to poll the GPIO fast enough not to have issues, but that's not a great assumption to be making. If this isn't working, we may have to investigate an interrupt-based solution
…or' into feature/ol2764RIT/hallEffectSensor
…or' into feature/ol2764RIT/hallEffectSensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just a few small things. Also don't forget to go through the unresolved comments and mark them. Once you have all of that, lets do one final test before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better than it did before, but there's a little more cleanup to do
Created the very new hallSensor class
-Goes through a GPIO read and assigns the correct case
-returns time
-returns distance traveled and speed
Created main for WSS using hall effect sensors
-Created representation of WSS using two hall effect sensors for back and front wheels
-Allow can transmission of data for validation of proper functionality