Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment version number to 0.1.4.9000 #433

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Increment version number to 0.1.4.9000 #433

merged 1 commit into from
Jan 12, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jan 8, 2024

Bump to dev version number.

@jdhoffa jdhoffa requested a review from jacobvjk January 8, 2024 18:00
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 8, 2024

@AlexAxthelm all checks seem to be failing, is this a known problem?
(follow-up, how did we get this onto CRAN with all the checks failing?)

@AlexAxthelm
Copy link
Contributor

@jdhoffa the checks look to me like they might be using the wrong version of r2dii.data?

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 9, 2024

@jdhoffa the checks look to me like they might be using the wrong version of r2dii.data?

Mauro wrote two different categories of tests. One test against the CRAN published version of r2dii.data (R-CMD-check), the other tests against the latest commit on main (R-CMD-check r2dii-devel)

All seem to fail.

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 10, 2024

Yeah I also get 11 failed tests locally.

How did this make it to CRAN??? Are we sure it was accepted @AlexAxthelm

Screenshot 2024-01-10 at 12 22 30

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 10, 2024

This PR is the culprit:
7a2b592

The call to skip_on_cran() there seems to skip about 87 tests.

Without skip() (179 total tests, 9 failing):
Screenshot 2024-01-10 at 12 34 07

with skip() (92 total tests, all passing):
Screenshot 2024-01-10 at 12 35 29

Those tests aren't skipped on CI and are why this PR is failing.

I will look into why all those tests are failing in a separate issue...

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 10, 2024

Blocked by #434

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 12, 2024

Actually, I'm going to force merge this, as whatever I do to fix these failing tests will need to be a "next release" kind of thing.

@jdhoffa jdhoffa merged commit 74c8bce into main Jan 12, 2024
1 of 22 checks passed
@jdhoffa jdhoffa deleted the dev_version_number branch January 12, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants