Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why 9 tests fail #434

Closed
jdhoffa opened this issue Jan 10, 2024 · 3 comments · Fixed by #435
Closed

Figure out why 9 tests fail #434

jdhoffa opened this issue Jan 10, 2024 · 3 comments · Fixed by #435
Assignees
Labels
bug an unexpected problem or unintended behavior

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Jan 10, 2024

This PR is the culprit:
7a2b592

The call to skip_on_cran() there seems to skip about 87 tests.

Without skip() (179 total tests, 9 failing):
Screenshot 2024-01-10 at 12 34 07

with skip() (92 total tests, all passing):
Screenshot 2024-01-10 at 12 35 29

Those tests aren't skipped on CI and are why this PR is failing.

I will look into why all those tests are failing in a separate issue...

Originally posted by @jdhoffa in #433 (comment)

@jdhoffa jdhoffa self-assigned this Jan 10, 2024
@jdhoffa jdhoffa added priority bug an unexpected problem or unintended behavior labels Jan 10, 2024
@AlexAxthelm
Copy link
Contributor

FYI, when I run devtools::test() from main on my machine, I get:

R4.3.2> devtools::test()
ℹ Testing r2dii.match
✔ | F W S  OK | Context
✔ |        10 | add_sector_and_borderline
✔ |         7 | check_crucial_names
✔ |         1 | crucial_lbk
✔ |         5 | helper-fake_lbk
✔ |        84 | match_name [2.5s]
✔ |        27 | prioritize
✔ |         7 | restructure_abcd
✔ |         5 | select_chr
✔ |        25 | to_alias
✔ |         4 | uniquify_id_column

══ Results ═══════
Duration: 3.3 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 175 ]

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 11, 2024

FYI, when I run devtools::test() from main on my machine, I get:

R4.3.2> devtools::test()
ℹ Testing r2dii.match
✔ | F W S  OK | Context
✔ |        10 | add_sector_and_borderline
✔ |         7 | check_crucial_names
✔ |         1 | crucial_lbk
✔ |         5 | helper-fake_lbk
✔ |        84 | match_name [2.5s]
✔ |        27 | prioritize
✔ |         7 | restructure_abcd
✔ |         5 | select_chr
✔ |        25 | to_alias
✔ |         4 | uniquify_id_column

══ Results ═══════
Duration: 3.3 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 175 ]

That is running the CRAN installations of both r2dii.data and r2dii.match?

@jdhoffa jdhoffa changed the title Figured out why 9 tests fail Figure out why 9 tests fail Jan 12, 2024
@AlexAxthelm
Copy link
Contributor

Hmm. it appears I was not. I'm also now. seeing failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants