Fix failing tests due to updated r2dii.data data
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI. @AlexAxthelm |
jacobvjk
reviewed
Jan 15, 2024
| @@ -268,7 +268,7 @@ test_that("works with `min_score = 0` (bug fix)", { | |||
| }) | |||
|
|
|||
| test_that("outputs only perfect matches if any (#40 @2diiKlaus)", { | |||
| this_name <- "large hdv company three" | |||
| this_name <- "Jacob" | |||
There was a problem hiding this comment.
AHahah it is genuinely a fake company name in the updated data @cjyetman made, ¯_(ツ)_/¯
Hmmm, I do not know why this test is failing... I would say this is not related directly to this PR (updating regressions from |
|
I have made a new issue in #436. I would suggest we merge this PR, and handle follow-up there. |
This was referenced Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a handful of things to ensure the tests are passing as is, mainly to do with adapting tests to the updated format of
loanbook_demo:I also removed the call to
skip_on_cran, as this should work fine now.No update to
NEWS.mdrequired, as this is not user-facing.Relates to #432
Closes #434