Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider *not* re-installing PACTA packages over those installed in the transitionmonitor image #53

Closed
cjyetman opened this issue Feb 26, 2024 · 3 comments

Comments

@cjyetman
Copy link
Member

# install PACTA R packages
RUN Rscript -e "pak::pkg_install(pkg = 'RMI-PACTA/pacta.data.scraping')"
RUN Rscript -e "pak::pkg_install(pkg = 'RMI-PACTA/pacta.portfolio.import')"
RUN Rscript -e "pak::pkg_install(pkg = 'RMI-PACTA/pacta.portfolio.allocate')"
RUN Rscript -e "pak::pkg_install(pkg = 'RMI-PACTA/pacta.portfolio.audit')"
RUN Rscript -e "pak::pkg_install(pkg = 'RMI-PACTA/pacta.portfolio.utils')"

The Dockerfile uses a transitionmonitordockerregistry.azurecr.io/rmi_pacta base image, which should already have all the relevant PACTA R packages installed, because it should be a fully functional PACTA image. Currently, the Dockerfile re-installs all the PACTA R packages again (from GitHub, and therefore the most current versions), which can lead to differing versions of the PACTA R packages being used then those that are included in the base image, which can lead to errors if breaking changes occurred between those versions.

@AlexAxthelm
Copy link
Contributor

Given that an important part of preparing indices is ensuring parity between the code running the analysis for a portfolio and the code running the analysis on the index benchmarks, I strongly support this.

@cjyetman
Copy link
Member Author

for some context, I tried running this for 2021Q4 and it didn't work because of a function signature change that happened since 2021Q4 benchmarks were last run

@cjyetman
Copy link
Member Author

superseded by #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants