Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/45 use DESCRIPTION #54

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Feat/45 use DESCRIPTION #54

merged 3 commits into from
Feb 26, 2024

Conversation

AlexAxthelm
Copy link
Contributor

Remove imports.R and use DESCRIPTION to manage dependencies instead.

@jdhoffa
Copy link
Member

jdhoffa commented Feb 26, 2024

Closes #45

@jdhoffa
Copy link
Member

jdhoffa commented Feb 26, 2024

Also closes #53 I think? @cjyetman

jdhoffa
jdhoffa approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cjyetman
Copy link
Member

FYI @jdhoffa I think this does not close #53 because the DESCRIPTION includes the PACTA packages and the Dockerfile uses pak::local_install_deps()

@cjyetman cjyetman linked an issue Feb 26, 2024 that may be closed by this pull request
Scrap imports.R and use a DESCRIPTION file #45
Closed
@AlexAxthelm AlexAxthelm merged commit cc3de8a into main Feb 26, 2024
@AlexAxthelm AlexAxthelm deleted the feat/45-use-description branch February 26, 2024 14:15
@AlexAxthelm
Copy link
Contributor Author

#53 is next on my list.

@jdhoffa
Copy link
Member

jdhoffa commented Feb 26, 2024

Thanks both!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman cjyetman approved these changes

@jdhoffa jdhoffa jdhoffa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrap imports.R and use a DESCRIPTION file
3 participants
@AlexAxthelm @jdhoffa @cjyetman