Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gains PA2024CH config #87

Merged
merged 1 commit into from
Feb 29, 2024
Merged

feat: gains PA2024CH config #87

merged 1 commit into from
Feb 29, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Feb 29, 2024

After #81, main.R now expects a project_code in the config.yml (which it uses to select the appropriate ProjectParmeters file in https://github.com/RMI-PACTA/workflow.transition.monitor

Since we want to pull the PA2024CH project_code (and I didn't want to have that value appear in a general 2023Q4 config), I made a more specific PA2024CH section in the config.

Note: This will require a change in the .env file to run appropriately.

@AlexAxthelm
Copy link
Contributor

@jdhoffa Is there a reason you didn't use the inherits keyword to have PA2024CH inherit from 2023Q4? (seems like it might have avoided #89)

@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 29, 2024

I think even if it were to inherit the confit, I would still have to select the PA2024CH as the R_CONFIG_ACTIVE.
And with the way it currently mounts things, would cause an issue.

I will think of a better solution when the time pressure is a little lessened :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants