Using a local entity resolver for XML, if possible #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, since XML file is re-parsed every time for every triple map (which should be optimized too, btw), those DTDs have to be re-downloaded again for every parsing pass. So it's downloading N .dtd files per M triple maps. Uh-oh 😉 |
|
I think that a proper catalog resolver should be used instead of this ad-hoc solution, actually. Will probably reiterate on this code later, if I have some more free time on my hands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using RMLmapper for a bunch of XML/XHTML files, and found out that whenever an XML file has a DOCTYPE entry,
DocumentBuilder(inXML.java) tries to pull those ".dtd" (and ".ent") files from their original sources on the web, e.g.:... which is its natural behaviour, but it becomes very slow (or even not usable) in case of slow/unavailable network connections.
As a quick solution, I've implemented the ability to resolve those XML entities using local DTD files, if those are available in CLASSPATH, or falling back to the default behaviour (pulling them from the web), if a local DTD file is not found.