This repository has been archived by the owner on May 14, 2024. It is now read-only.
Fix for rsp files on Windows. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxsamliu
reviewed
Jul 10, 2023
| @@ -371,6 +371,15 @@ BEGIN | |||
| $hsacoVersion = $arg; | |||
| $swallowArg = 1; | |||
| } | |||
| if($arg =~ /\.rsp$/) { | |||
There was a problem hiding this comment.
Do you have an example response file that this patch is trying to fix? What is the error without this patch?
There was a problem hiding this comment.
The error that we see is one hip-tests, GraphTests have grown in size and the final linkage line is too big on windows.
For now we have fixed it via a hack: ROCm/hip-tests@fe9515a basically split it in two exe till we have a fix in place.
To fix this we need to enable rsp files inside hip-tests CMake (done via: ROCm/hip-tests#360 ) but before that hipcc needs to escape rsp files and add proper encoding for windows.
There was a problem hiding this comment.
Edit: we got same error for memory tests as well: ROCm/hip-tests#362
kzhuravl
approved these changes
Jul 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File names starting with @ can not be escaped.
This is needed for really long command lines with tests on windows