Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding find package for hsa-runtime64, hsakmt, hip, rocm_smi, hiprand & rocrand #854

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

renjithravindrankannath
Copy link
Contributor

Adding find package for hsa-runtime64, hsakmt, hip, rocm_smi, hiprand & rocrand.
Updated cmake for the tests with the include and library path variables.

@renjithravindrankannath
Copy link
Contributor Author

Built, generated, package, installed successfully and ran the tests in Centos8 with MI50 environment.
Attached the console log -> RVS_PR-854-test.txt
Please review and approve.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
edp.so/CMakeLists.txt Show resolved Hide resolved
Copy link
Collaborator

@manoj-freyr manoj-freyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jkottiku jkottiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
If testing on all distros completed, go ahead and merge.

@renjithravindrankannath
Copy link
Contributor Author

Looks good. If testing on all distros completed, go ahead and merge.
Please find the below validation logs.
RVS_PR-854-Centos.txt
RVS_PR-854-test-01-14-RHEL.txt
RVS_PR-854-test-01-11-Ubuntu.txt

@renjithravindrankannath renjithravindrankannath merged commit bd63256 into ROCm:master Jan 20, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants