Resolve import conflicts with installed triton library by renaming op_tests.triton for modular imports
#329
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the local op_tests/triton directory to op_tests/triton_tests to avoid import conflicts with the installed Triton package. Key changes include:
- Renaming the directory and updating import paths.
- Adding init.py files with standardized licensing headers.
- Ensuring that the op_tests/triton_tests/init.py imports are set to expose utility modules.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| op_tests/triton_tests/utils/init.py | Added licensing header and wildcard imports from utility modules. |
| op_tests/triton_tests/init.py | Added licensing header and re-exported utils. |
| op_tests/init.py | Added licensing header. |
|
still some issue caused triton ut failed |
|
@valarLip updated imports in op_tests.triton_tests to use relative paths. Issue should be resolved now. Thanks for taking a look. |
valarLip
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename op_tests/triton/ --> op_tests/triton_tests/ to avoid conflicts with the installed Triton package.
Python's import system prioritizes local directories over site-packages, causing
import triton.languageto incorrectly resolve to the local op_tests/triton/ folder.This change ensures imports correctly target the installed Triton library. No functional changes — only directory renaming and minor import path updates.