-
Notifications
You must be signed in to change notification settings - Fork 250
Ck tile batched contraction kernel generelizing #3126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msaffari-amd
wants to merge
16
commits into
develop
Choose a base branch
from
ck_tile_batched_contraction_kernel_generelizing
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+676
−307
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
356b50f
Add help for example
msaffari-amd b161cd9
Refactore the compute reference batched contraction to manage stride-…
msaffari-amd 553c05e
Merge branch 'develop' into ck_tile_batched_contraction_kernel_genere…
msaffari-amd 4027a92
Add stride-aware reference for batched contraction with independent D…
msaffari-amd 9fc1a8c
Add -num_d argument for runtime D tensor count selection in batched c…
msaffari-amd fec8332
Add stride vector arguments in example code for testing non-contiguou…
msaffari-amd 2ecb0bf
Add descriptor-based architecture for batched contraction multi-dimen…
msaffari-amd b8b56d5
Add multi-dimensional non-contiguous stride support to batched contra…
msaffari-amd bbfe450
Add complete multi-dimensional stride support via descriptors
msaffari-amd 6144f5c
Enable vectorization in descriptor-based batched contraction. Add pad…
msaffari-amd 4883883
Clean up batched contraction: remove old UniversalGemmKernel path
msaffari-amd 670409c
merge develop
msaffari-amd e7f5f0b
Clean up batched contraction: remove legacy paths and finalize docs
msaffari-amd 0eb1b55
Optimize batched contraction example: pass dimension sizes not vectors
msaffari-amd 11514c7
Merge branch 'develop' into ck_tile_batched_contraction_kernel_genere…
msaffari-amd c3857ee
Merge branch 'develop' into ck_tile_batched_contraction_kernel_genere…
msaffari-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -219,9 +219,8 @@ float batched_contraction(const ck_tile::BatchedContractionHostArgs<DsDataType:: | |
| HANDLE_CASE(2, 1, 1, 1); | ||
| HANDLE_CASE(2, 2, 2, 1); | ||
| HANDLE_CASE(1, 2, 1, 1); | ||
| HANDLE_CASE(1, 1, 1, 2); | ||
| HANDLE_CASE(2, 1, 1, 1); | ||
| HANDLE_CASE(2, 2, 2, 2); | ||
| HANDLE_CASE(4, 4, 4, 4); | ||
|
Comment on lines
-222
to
-224
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why removing those two? |
||
|
|
||
| throw std::runtime_error( | ||
| "Unsupported dimension combination: G=" + std::to_string(num_g_dims) + | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate case
HANDLE_CASE(2, 1, 1, 1)at lines 219 and 222. The second occurrence at line 222 appears to replace a removed case for (1, 1, 1, 2), which may be intentional removal but the duplicate is incorrect. Remove line 222 or replace it with the intended dimension combination.