Control flow fixes #195
Open
Control flow fixes #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLagos
reviewed
Nov 6, 2025
KenLagos
left a comment
KenLagos
left a comment
There was a problem hiding this comment.
Did a quick look but just to double check isn't this PR functionally almost the same as the other one?
This appears to disable subgraph fusion for subgraphs with an "If" as its parent node and has a different way to handle the incorrect index issue.
The main difference is it doesn't disable fusion in cases where the current subgraph has an "If" node but depends on a Migraphx change to work.
If the migraphx change works fine with no regressions I think this change is fine.
Collaborator
Author
|
Merged the other branch which contains this into rocm7.1_internal_testing. Will keep branch alive till you retest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Used for debug from TritonInferenceServer changes
Motivation and Context
Fixes issues seen with models using the IF/Loop/Scan operators